fix: improved error handling, avoiding huge log files #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikBjare
force-pushed
the
dev/error-handling
branch
2 times, most recently
from
82713b6 to
9839c1e
Compare
ErikBjare
commented
Oct 26, 2022
ErikBjare
commented
Oct 26, 2022
ErikBjare
force-pushed
the
dev/error-handling
branch
from
9839c1e to
d015db1
Compare
2 tasks
| # HTTP 400 - Bad request | ||
| # Example case: https://github.com/ActivityWatch/activitywatch/issues/815 | ||
| # We don't want to retry, because a bad payload is likely to fail forever. | ||
| logger.error("Bad request, not retrying: {}".format(request.data)) |
There was a problem hiding this comment.
Maybe also log the response from the server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.